-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple occurrences of design matrix #9583
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #9583 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9583 +/- ##
==========================================
+ Coverage 91.85% 91.88% +0.02%
==========================================
Files 433 433
Lines 26768 26804 +36
==========================================
+ Hits 24587 24628 +41
+ Misses 2181 2176 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -47,9 +47,11 @@ def test_analysis_config_from_file_is_same_as_from_dict(monkeypatch, tmp_path): | |||
("STD_ENKF", "ENKF_TRUNCATION", 0.8), | |||
], | |||
ConfigKeys.DESIGN_MATRIX: [ | |||
"my_design_matrix.xlsx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these style changes intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it becomes a list of lists, so yes it is intentional 😄
with pytest.raises(ValueError, match=error_msg): | ||
design_matrix_1.merge_with_other(design_matrix_2) | ||
else: | ||
design_matrix_1.merge_with_other(design_matrix_2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we check that the parameter configuration is as expected here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also check/assert that the contents of the df are as expected?
Issue
Resolves #9532
Approach
todo
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable