Remove records concept for parameters & responses #10941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
25.05.remove-records
branch
from
dc8d853 to
e648a5c
Compare
yngve-sk
force-pushed
the
25.05.remove-records
branch
5 times, most recently
from
815dc92 to
febf012
Compare
yngve-sk
force-pushed
the
25.05.remove-records
branch
6 times, most recently
from
82c8ce6 to
4d8d655
Compare
yngve-sk
force-pushed
the
25.05.remove-records
branch
9 times, most recently
from
3885865 to
30e88fa
Compare
oyvindeide
reviewed
Jun 12, 2025
yngve-sk
force-pushed
the
25.05.remove-records
branch
3 times, most recently
from
5c4c839 to
1c5d629
Compare
yngve-sk
force-pushed
the
25.05.remove-records
branch
from
b4a931b to
4b7d2d9
Compare
Should only be omitted until they can be handled by plotter
yngve-sk
force-pushed
the
25.05.remove-records
branch
from
4b7d2d9 to
19e2334
Compare
CodSpeed Performance ReportMerging #10941 will improve performances by ×6Comparing Summary
Benchmarks breakdown
|
oyvindeide
approved these changes
Jun 18, 2025
Comment on lines
+116
to
+117
| assert response_key is not None | ||
| assert response_type is not None |
There was a problem hiding this comment.
Can they actually be None? Or is the typing wrong?
There was a problem hiding this comment.
Suggest deferring to separate issue to remove the None typing.
Webviz-ert fails when it is removed, giving this:
File "webviz-ert/webviz_ert/data_loader/__init__.py", line 307, in compute_misfit
response_key, report_step = response_name.split("@", 1)
^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: not enough values to unpack (expected 2, got 1)
, and these tests fail:
test_data_for_response_doesnt_mistake_history_for_response
test_plot_api_handles_urlescape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #10684
Resolves #9059
Approach
Make separate endpoints for params and responses
PS: Will look into adding webviz ert plots into ert plotter to not maintain backward compat. The removals of some endpoints in this PR can be considered blocked by that.