Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor update workflow signature #9607

Open
oyvindeide opened this issue Dec 20, 2024 · 0 comments · May be fixed by #9688
Open

Refactor update workflow signature #9607

oyvindeide opened this issue Dec 20, 2024 · 0 comments · May be fixed by #9688
Assignees
@frode-aarstad

Comments

@oyvindeide
Copy link
Collaborator

oyvindeide commented Dec 20, 2024 •
edited
Loading

Currently the UpdateWorkflow takes in ESSettings in the constructor, but should just the base settings:

ert/src/ert/config/analysis_module.py

Line 19 in 1889e2a

class BaseSettings(BaseModel):
, as no particular algorithm is configured for this, yet. The run models for the other algorithms should require the corresponding configuration that they depend on. For example the ensemble_smoother should have:

ert/src/ert/config/analysis_module.py

Line 64 in 719a81e

class ESSettings(BaseSettings):
in the constructor, as there is no need for the settings for IES:

ert/src/ert/config/analysis_module.py

Line 91 in 719a81e

class IESSettings(BaseSettings):

@oyvindeide oyvindeide moved this to Todo in SCOUT Jan 6, 2025
@frode-aarstad frode-aarstad moved this from Todo to In Progress in SCOUT Jan 9, 2025
@frode-aarstad frode-aarstad self-assigned this Jan 9, 2025
@frode-aarstad frode-aarstad linked a pull request Jan 9, 2025 that will close this issue
Open
9 tasks
@frode-aarstad frode-aarstad moved this from In Progress to Ready for Review in SCOUT Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frode-aarstad frode-aarstad

Labels
None yet
Projects
SCOUT
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor update workflow signature frode-aarstad/ert
2 participants
@frode-aarstad @oyvindeide