chore: remove unused methods #704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unused? avoid using because it is not intuitive? complicates things? Refs: ECALC-1830
jsolaas
approved these changes
Nov 19, 2024
| key: CSVFormatter( | ||
| separation_character="\t", index_formatters=PeriodFormatterConfig.get_row_index_formatters() | ||
| ).format(val) | ||
| for key, val in result.items() |
There was a problem hiding this comment.
Suggested change
| for key, val in result.items() | |
| for key, val in result.groups |
Maybe we should move the loop in groups in here instead, since FilteredResult don't need to know about Formattable. Unnecessary coupling
There was a problem hiding this comment.
I'm struggling with the directory structure we currently have. Should Formattable be placed in domain, FormattableGroupedQuery in infrastructure etc.? Or should we have a similar structure within presentation.exporter? What is "important" enough to be considered domain. When I think about it I just want to separate interfaces from implementations, so formattable could be in the domain, but it isn't what I think of as the core ecalc domain.....Should Formatter be a completely separate module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unused? avoid using because it is not intuitive? complicates things?
Refs: ECALC-1830
Have you remembered and considered?
docs/drafts/next.draft.md)docs/docs/migration_guides/)BREAKING:in footer or!in header, if breakingECALC-XXXX)Why is this pull request needed?
This pull request is needed because of....
What does this pull request change?
Write summary of what this pull request changes if needed.
Issues related to this change: