Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecalc 1379 #567

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Ecalc 1379 #567

wants to merge 5 commits into from

Conversation

olelod
Copy link
Contributor

@olelod olelod commented Aug 15, 2024

Have you remembered and considered?

  • I have remembered to update documentation
  • I have remembered to update manual changelog (docs/docs/changelog/next.md)
  • I have remembered to update migration guide (docs/docs/migration_guides/)
  • I have committed with BREAKING: in footer or ! in header, if breaking
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Jira issue ID somewhere in the commit body (ECALC-XXXX)

Why is this pull request needed?

This pull request is needed because of....

What does this pull request change?

Write summary of what this pull request changes if needed.

Issues related to this change:

variables_map=variables_map,
)
regularity = [
1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this also apply to timesteps at the end of the global time vector, if e.g. the input file with regularity ends at 2024, but the global time vector goes to 2026? Often, it is (or was) set explicitly to 0 in the last timestep (for different type of data, regularity, produiction etc), as an explicit end to make sure that extrapolation worked for the few remainign timesteps at the end - and in that case regularity should be 0, and not 1...right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is correct for missign timesteps in the beginning and in the middle of the global time vector, but not at the end. or perhaps those in the middle should be interpolated (as you do I think?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants