Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renv guides to update renv.lock file #67

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

avallecam
Copy link
Member

Fix #58

@avallecam
Copy link
Member Author

hi @pratikunterwegs I briefly added guidelines. could we have your brief review?

Copy link
Contributor

@pratikunterwegs pratikunterwegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @avallecam, this looks good to me. Could you also mention when to use renv::update() and renv::upgrade(), and whether that should be done in a separate PR from adding an analysis.

@avallecam
Copy link
Member Author

avallecam commented Jun 4, 2024

Could you also mention when to use renv::update() and renv::upgrade(), and whether that should be done in a separate PR from adding an analysis.

Appropriate suggestion. Added in b8ed421 and b89a36a

@pratikunterwegs
Copy link
Contributor

Great thanks!

@avallecam
Copy link
Member Author

thanks, I'll merge this then

@avallecam avallecam merged commit c019773 into main Jun 5, 2024
2 checks passed
@avallecam avallecam deleted the add-renv-guides branch June 5, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add how to update the renv.lock file to the CONTRIBUTING file
2 participants