Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renv and lockfile #59

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

pratikunterwegs
Copy link
Contributor

This PR fixes #50 as follows:

  1. Updates renv to v1.0.7
  2. Updates the renv lockfile with R v4.4.0 and new package versions.

@pratikunterwegs pratikunterwegs requested a review from avallecam May 30, 2024 14:08
@pratikunterwegs pratikunterwegs self-assigned this May 30, 2024
@pratikunterwegs
Copy link
Contributor Author

I'm not really sure why there's an issue with installing {StanHeaders}, will look into it.

@avallecam
Copy link
Member

I'm not really sure why there's an issue with installing {StanHeaders}, will look into it.

thank you for setting this up. should we wait for {StanHeaders} to update dependencies to let this PR pass all checks and merge before merging #57 or #60 right? Is it possible to estimate this update to should we re-run the workflow?

@pratikunterwegs
Copy link
Contributor Author

Hi @avallecam, this PR is failing checks because one or more of the workflows uses the function epiparameter::epiparam(), which has been removed in more recent version of {epiparameter}. I'll file a separate issue for replacing this usage with epiparameter::epidist_db(). I would also suggest putting the render workflow on a monthly CRON job so that we know of breaking changes in packages under development.

@avallecam
Copy link
Member

@pratikunterwegs epiparameter::epiparam() was replaced in #63 I needed to update some other packages (R.utils, arm, matrix) in order to pass all checks. Are you able to rebase and solve conflicts in this PR?

@pratikunterwegs
Copy link
Contributor Author

I'm pushing changes to this PR after rebasing on main so will wait for checks to run.

@pratikunterwegs
Copy link
Contributor Author

Hi @avallecam this PR is now ready to review.

Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, nothing to add, ready to merge 🚀

@pratikunterwegs pratikunterwegs merged commit 55c8425 into epiverse-trace:main Jun 5, 2024
2 checks passed
@pratikunterwegs pratikunterwegs deleted the update-renv branch June 5, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

update {howto} renv lock file
2 participants