Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get one copy and paste chunk in each entry #51

Merged
merged 5 commits into from
Jun 6, 2024
Merged

get one copy and paste chunk in each entry #51

merged 5 commits into from
Jun 6, 2024

Conversation

avallecam
Copy link
Member

Fix #43

@avallecam avallecam changed the title get on copy and paste chunk in each entry get one copy and paste chunk in each entry Apr 8, 2024
@avallecam avallecam requested a review from Bisaloo April 9, 2024 11:59
Bisaloo
Bisaloo reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we still don't always get a single chunk because of figures. It can be changed by adding fig.show = "hold" in the knitr options but I'm not completely sure it's desirable.

@avallecam
Copy link
Member Author

Note that we still don't always get a single chunk because of figures. It can be changed by adding fig.show = "hold" in the knitr options but I'm not completely sure it's desirable.

thank you for reporting this! I'll take a further look.

@avallecam avallecam mentioned this pull request Jun 6, 2024
Merged
5 tasks
@avallecam
Copy link
Member Author

Note that we still don't always get a single chunk because of figures. It can be changed by adding fig.show = "hold" in the knitr options but I'm not completely sure it's desirable.

I block the intermediate plots. Only in one entry, I decided to use patchwork to show two plots to compare at the end 95c93a1

These style decisions are now included in the contributing guide too 6456543

@avallecam avallecam merged commit e91b8d8 into main Jun 6, 2024
2 checks passed
@avallecam avallecam deleted the fix/copy-paste branch June 6, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bisaloo Bisaloo Bisaloo left review comments

Assignees
No one assigned
Labels
None yet
Projects
learn-maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should we make the code ready to copy and paste for reuse?
2 participants
@avallecam @Bisaloo