Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 48: Ebola vignette #52

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Issue 48: Ebola vignette #52

wants to merge 13 commits into from

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented May 21, 2024

Description

Status: work in progress! Contains material best written after package redevelopment -- can be used for DDD

This PR will close #48. The point of this vignette is to demonstrate some of the more advanced capabilities of the epidist package.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes changed the title Template for second vignette Issue 48: Ebola vignette May 21, 2024
@athowes
Copy link
Collaborator Author

athowes commented May 27, 2024

Did you ever fit different delay distributions by sex or other covariates @seabbs @parksw3 for the ebola data?

That seems like a fun thing to do and would demonstrate some of the functionality of having this brms set-up.

@parksw3
Copy link
Collaborator

parksw3 commented May 29, 2024

We did not. And I agree it would be a really useful demonstration. Currently packing to get ready to move to Canada tomorrow... will engage more after I move...

@seabbs
Copy link
Contributor

seabbs commented May 29, 2024

Agree with both of you that this would be a nice thing to at least plan to do here as its within the functionality of the current package but hasn't been explored but is suggested as a good idea in Charniga et al. I say plan as we need to make sure any current design decisions don't close the door on this but if time also just doing it now would be good.

@athowes
Copy link
Collaborator Author

athowes commented May 30, 2024

Note to self that after working on the in depth model vignette (#66) I am now in more of a position to implement a basic version of the gamma delay into this PR.

@athowes athowes self-assigned this May 30, 2024
@athowes
Copy link
Collaborator Author

athowes commented Jun 6, 2024

Updates based on #70:

  • Can now do gamma
  • Can now do formula for by space or sex more easily
  • Need to update otherwise to be compatible with new function name

@athowes athowes added the active PRs that are being actively worked on label Jun 12, 2024
@athowes athowes mentioned this pull request Jun 12, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
active PRs that are being actively worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create longer form DDD vignette
3 participants