Skip to content

Commit

Permalink
Update actions with links and a checklist (#225)
Browse files Browse the repository at this point in the history
* Update greeting with links.

* Create pr-checklist.yaml

* some vague attempt at correct syntax

* less vague attempt

* failing upwards

* version

* less complex message

* complex message back in

* Update pr-checklist.yaml

* Update pr-checklist.yaml

* try writing as a very long string

* longer

* Update pr-checklist.yaml

* text tweaks

* only run when created

* syntax
  • Loading branch information
seabbs authored Apr 1, 2021
1 parent 85474dd commit 89e9399
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/greetings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ jobs:
- uses: actions/first-interaction@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: "Thanks for opening an issue! We'll try and get back to you shortly."
pr-message: 'Thank you for opening this PR. Please check you have read through our developer guidelines before requesting review.'
issue-message: "Thanks for opening an issue! We'll try and get back to you shortly. If you've identified an issue and would like to fix it please see our [contribution guidelines](https://github.com/epiforecasts/covidregionaldata/tree/master/.github/CONTRIBUTING.md)."
pr-message: 'Thank you for opening this PR. Please check you have read through our [developer guidelines](https://github.com/epiforecasts/covidregionaldata/tree/master/.github/CONTRIBUTING.md) before requesting review.'
17 changes: 17 additions & 0 deletions .github/workflows/pr-checklist.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
on:
pull_request:
types: [opened]

jobs:
pr-checklist:
runs-on: ubuntu-latest
steps:
- uses: actions/github-script@v3
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
github.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: '👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant). \n\n - [ ] Read our [contribution guidelines](https://github.com/epiforecasts/covidregionaldata/tree/master/.github/CONTRIBUTING.md) if you have not already done so. \n- [ ] If you have altered an existing class please run the tests locally (using `devtools::load_all(); devtools::test()`) first setting `options(testDownload=TRUE, testSource=class-name)` and report your findings. \n- [ ] If you have added a new data class please run the tests locally for that class (using `devtools::load_all(); devtools::test()`). \n- [ ] Check your code passes our CI checks and review any style and code coverage warnings. \n- [ ] Comment with details if unable to get our CI checks to pass or unable to remove all warnings. \n\nThank you again for the contribution. If making large scale changes consider using our `pre-commit` hooks (see the [contributing guide](https://github.com/epiforecasts/covidregionaldata/tree/master/.github/CONTRIBUTING.md)) to more easily comply with our guidelines.'})

0 comments on commit 89e9399

Please sign in to comment.