-
Notifications
You must be signed in to change notification settings - Fork 38
Update vignette to reference epidist and primarycensored packages #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request expands the WORDLIST with new entries and reorganises existing items, whilst updating vignette documentation to reference the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
inst/WORDLIST(3 hunks)vignettes/estimate_infections_workflow.Rmd(1 hunks)vignettes/estimate_infections_workflow.Rmd.orig(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-23T20:57:00.615Z
Learnt from: jamesmbaazam
Repo: epiforecasts/EpiNow2 PR: 695
File: vignettes/benchmarks.Rmd:45-45
Timestamp: 2025-07-23T20:57:00.615Z
Learning: In the EpiNow2 project, vignettes/benchmarks.Rmd is a rendered output file generated from vignettes/benchmarks.Rmd.orig. The source .Rmd.orig file uses proper dynamic core detection with inline R expressions, and the rendered .Rmd shows the evaluated results from when it was knitted.
Applied to files:
vignettes/estimate_infections_workflow.Rmd.orig
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: lint-changed-files
- GitHub Check: pkgdown
- GitHub Check: R-CMD-as-cran-check
- GitHub Check: test-coverage
- GitHub Check: ubuntu-latest (devel)
- GitHub Check: windows-latest (release)
- GitHub Check: ubuntu-latest (oldrel-1)
- GitHub Check: macOS-latest (release)
- GitHub Check: ubuntu-latest (release)
🔇 Additional comments (3)
vignettes/estimate_infections_workflow.Rmd.orig (1)
109-110: Source file updated correctly.The documentation changes in the source file match those in the rendered output. The references to
primarycensoredandepidistare correctly updated.Note: Verification of URLs and the wrapper claim was requested in the review of the rendered file (vignettes/estimate_infections_workflow.Rmd).
inst/WORDLIST (2)
52-52: Good addition for spell-checking.The
epidistpackage name is correctly added to the wordlist, supporting the vignette documentation updates.
162-162: Good addition for spell-checking.The
primarycensoredpackage name is correctly added to the wordlist, supporting the vignette documentation updates.Note: The wordlist also includes many other additions throughout the file, which appear to be general maintenance to expand lexical coverage for the package's terminology. These are appropriate housekeeping changes.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
NOTE: To be merged after #1140
Summary
{epidist}and{primarycensored}packages instead of the outdated{dynamicaltruncation}referenceestimate_delays()is a wrapper around{primarycensored}Fixes #1173
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit