Open
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
🔎 Preview deployed: https://epicflare-pr-67.kentcdodds.workers.dev Worker: Mocks:
|
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
| resolve(code) | ||
| }) | ||
| }) | ||
| } |
There was a problem hiding this comment.
Process exit promise can hang forever after early exit
Medium Severity
waitForExit creates a new proc.once('exit', ...) listener each call. Unlike Bun's proc.exited (a reusable Promise that resolves immediately if already settled), a fresh once('exit') listener won't fire if the process already exited. If the child process crashes before stopProcess runs (e.g., during Symbol.asyncDispose), waitForExit returns a promise that never resolves, causing await exitPromise after SIGKILL to hang the test forever.
Additional Locations (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
bun:testtovitestTesting
bun run test:unitbunx vitest run mock-servers/resend/resend-mock.test.tsbun run test:mcpbun run typecheck && bun run lint