-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/migrate to react router 7 #897
base: main
Are you sure you want to change the base?
Feat/migrate to react router 7 #897
Conversation
Co-authored-by: Kent C. Dodds <[email protected]>
Some comments to be made:
|
Looks like the gcn SEO package is not being actively maintained. We could switch to: https://www.npmjs.com/package/@forge42/seo-tools |
https://docs.sentry.io/platforms/javascript/guides/react-router/ Might be helpful for the Sentry stuff. I haven't tried myself yet though. |
@stephen776 Thanks! Looks like they updated the docs a bit. I'll check it out soon and see where we can update |
Looks like framework mode is not yet supported thus we have to wait until Sentry is supporting this It does look like it can take a while (speaking about months) before a dedicated version is released: getsentry/sentry-javascript#14519 Following the React/Node integration from the link above will get you close enough for now. |
Saw that the httpIntegration and prismaIntegration are exported from the |
Amazing effort here! Thank you so much for doing this. It's been a crazy few months, but I'm finally going to start getting back to work next week and I'll get to this (probably live on stream!!). I love seeing the green CI checks 💚 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Rather than defining SerializeFrom
, it is possible to directly utilize the types from the .react-router
folder as follows:
import { type Route, type Info } from './+types/profile.connections.ts
...
export async function loader({ request }: Route.LoaderArgs) {
...
export const headers: Route.HeadersFunction = ({ loaderHeaders }) => {
...
export async function action({ request }: Route.ActionArgs) {
...
export default function Connections({ loaderData }: Route.ComponentProps) {
...
function Connection({
connection,
canDelete,
}: {
connection: Info['loaderData']['connections'][number]
canDelete: boolean
}) {
...
';
Made the first changes to go from RemixV2 to React Router 7. These are only the basic changes to be made and I'm working on the dev and prod server, but they don't seem to work out of the box.
Sentry did not work so this has been updated to use different packages provided by them. We do miss some of the current integrations though.
On a different project I do got the dev and prod server working, but I had to change quite some code. I'll test this through and see if this is really necessary or not.
@hakimLyon I did start from your PR, created a new one though.