[feature][WPN-270] Create and delete route for "/labs/" #25
Conversation
| "namespace": self.namespace, | ||
| "labels": { | ||
| "app": "wp-nginx", | ||
| "route": "public" |
There was a problem hiding this comment.
Will all our routes be public? Asking for inside.epfl.ch.
There was a problem hiding this comment.
Routes created only for "labs" -> line 698 -> so they have to be "public"
There was a problem hiding this comment.
So the function's name should be create_labs_route? Maybe the "public" should be a parameter so the function is generic?
There was a problem hiding this comment.
As discussed today, route will also be used at least for subdomains, so a generic function would be better.
wp-operator.py
Outdated
| except ApiException as e: | ||
| if e.status != 404: | ||
| raise e | ||
| logging.info(f" ↳ [{self.namespace}/{self.name}] Route object {route_name} already deleted") |
There was a problem hiding this comment.
Route object {route_name} does not exist rather than already deleted?
There was a problem hiding this comment.
Same as line 376
There was a problem hiding this comment.
So the line 376 should be changed too?
dragonleman
changed the title
dragonleman
changed the title
dragonleman
changed the title
Create and delete route for /labs/ only