#5988 - Exception when modifying a functional group after adding a ketcher editor subscription

[askyel]

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)
In issue #5988, the structure in the canvas disappeared when the editor was configured with a custom change subscription and a functional group was replaced with a different atom.
The error thrown is that the _inverted field on the s-group attribute operations are undefined, but assumed to be defined here:

ketcher/packages/ketcher-react/src/script/editor/utils/customOnChangeHandler.ts

Line 46 in f873318

switch (op.type) {

An operation's _inverted field is only set after the perform function is executed here:

ketcher/packages/ketcher-core/src/application/editor/operations/base.ts

Lines 41 to 48 in f873318

	perform(restruct: ReStruct): BaseOperation {
	this.execute(restruct);
	if (!this._inverted) {
	this._inverted = this.invert();
	this._inverted._inverted = this;
	}
	return this._inverted;
	}

The change in this PR moves the perform function execution from before the s-group attribute operations were added to after, such that those operations also have their _inverted field set.
I tested the same behavior as in the issue locally and this change solves the issue:
https://github.com/user-attachments/assets/8b9764a3-1074-40de-a821-9e44cb16a9d9

Note that the _inverted field still can be undefined in the customOnChangeHandler for other operations and this PR does not address that issue.

Check list

• unit-tests written
• e2e-tests written
• documentation updated
• PR name follows the pattern #1234 – issue name
• branch name doesn't contain '#'
• PR is linked with the issue
• base branch (master or release/xx) is correct
• task status changed to "Code review"
• reviewers are notified about the pull request

[rrodionov91]

Dear @askyel
May I ask you to rebase from latest master please? It should fix failed tests.

[askyel]

Dear @askyel May I ask you to rebase from latest master please? It should fix failed tests.

Yes, it should be updated now