Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4069 Right-click context menu protrudes beyond edges of the Ketcher workspace #5182

Merged
merged 10 commits into from
Jul 31, 2024
Merged

#4069 Right-click context menu protrudes beyond edges of the Ketcher workspace #5182

merged 10 commits into from
Jul 31, 2024

Conversation

KristinaKasyanovskaya
Copy link
Collaborator

@KristinaKasyanovskaya KristinaKasyanovskaya commented Jul 26, 2024 •
edited
Loading

Issue => #4069

Past behavior

  • Right-click context menu protrudes beyond edges of the Ketcher workspace.

Actual bahavior

  • Right-click context menu don't protrudes beyond edges of the Ketcher workspace.

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@KristinaKasyanovskaya KristinaKasyanovskaya linked an issue Jul 26, 2024 that may be closed by this pull request
Right-click context menu protrudes beyond edges of the Ketcher workspace #4069
Closed
@auto-assign auto-assign bot requested a review from Zhirnoff July 26, 2024 16:22
@KristinaKasyanovskaya KristinaKasyanovskaya changed the title #4069 Right-click context menu protrudes beyond edges of the Ketcher workspace WIP #4069 Right-click context menu protrudes beyond edges of the Ketcher workspace Jul 26, 2024
@KristinaKasyanovskaya KristinaKasyanovskaya changed the title WIP #4069 Right-click context menu protrudes beyond edges of the Ketcher workspace #4069 Right-click context menu protrudes beyond edges of the Ketcher workspace Jul 30, 2024
@NataliaLoginova NataliaLoginova merged commit c484e56 into master Jul 31, 2024
5 checks passed
@NataliaLoginova NataliaLoginova deleted the 4069-right-click-context-menu-protrudes-beyond-edges-of-the-ketcher-workspace branch July 31, 2024 07:58
Guch1g0v pushed a commit that referenced this pull request Oct 17, 2024
@KristinaKasyanovskaya @rrodionov91 @Guch1g0v
#4069 Right-click context menu protrudes beyond edges of the Ketcher…
94b2304 
… workspace (#5182)

* feat: add new logic for modal windows

* feat:changed some of the functional logic

* feat: change style in toggleButtonGroup

* feat: add styles and logic for context menu

* feat: update test

* - fixed context menu position calculation from ketcher window instead of document

* - removed timeout

* - updated screenshots

---------

Co-authored-by: Roman Rodionov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrodionov91 rrodionov91 rrodionov91 approved these changes

@NataliaLoginova NataliaLoginova NataliaLoginova approved these changes

@svvald svvald svvald approved these changes

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@KristinaKasyanovskaya KristinaKasyanovskaya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Right-click context menu protrudes beyond edges of the Ketcher workspace
4 participants
@KristinaKasyanovskaya @svvald @NataliaLoginova @rrodionov91