Skip to content

Commit

Permalink
skip: update CI 220
Browse files Browse the repository at this point in the history
  • Loading branch information
vit-corp committed Aug 27, 2024
1 parent f8ed07f commit e30dc3b
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 16 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/auto-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
resource_priority_list:
type: string
description: Priority list for resources (you can remove unnecessary resources during testing)
default: '["postgresql"]'
default: '["postgresql", "cosmosdb"]'
#'["storage", "webapp", "vnet", "network", "vm", "synapse", "sql", "mysql", "subscription", "disk", "postgresql", "cosmosdb", "signalr", "spring", "search", "service-fabric", "stream", "redis", "servicebus", "role", "monitor", "machine-learning", "logic", "kusto", "aks", "keyvault", "iothub", "front-door", "event", "data", "defender", "container", "cognitiveservice", "batch", "automation", "application", "app-configuration", "api", "alert"]'
required: true

Expand All @@ -24,7 +24,7 @@ env:
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
AZURE_SECRET_VALUE: ${{ secrets.AZURE_SECRET_VALUE }}
default_resource_priority_list: '["postgresql"]'
default_resource_priority_list: '["postgresql", "cosmosdb"]'
#default_resource_priority_list: '["storage", "webapp", "vnet", "network", "vm", "synapse", "sql", "mysql", "subscription", "disk", "postgresql", "cosmosdb", "signalr", "spring", "search", "service-fabric", "stream", "redis", "servicebus", "role", "monitor", "machine-learning", "logic", "kusto", "aks", "keyvault", "iothub", "front-door", "event", "data", "defender", "container", "cognitiveservice", "batch", "automation", "application", "app-configuration", "api", "alert"]'
TF_VAR_project: ${{ secrets.TF_VAR_project }}
TF_VAR_region: ${{ secrets.AWS_REGION }}
Expand Down
2 changes: 1 addition & 1 deletion auto_policy_testing/green/cosmosdb/cosmosdb.tf
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ resource "azurerm_cosmosdb_account" "this" {

ip_range_filter = "127.0.0.1"

# key_vault_key_id = data.terraform_remote_state.common.outputs.key_versionless_id
key_vault_key_id = data.terraform_remote_state.common.outputs.key_versionless_id

access_key_metadata_writes_enabled = false

Expand Down
22 changes: 11 additions & 11 deletions auto_policy_testing/green/cosmosdb/key_vault.tf
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#data "azurerm_client_config" "current" {}
data "azurerm_client_config" "current" {}

#data "azuread_service_principal" "cosmosdb" {
# display_name = "Azure Cosmos DB"
#}
data "azuread_service_principal" "cosmosdb" {
display_name = "Azure Cosmos DB"
}

#resource "azurerm_key_vault_access_policy" "cosmosdb" {
# key_vault_id = data.terraform_remote_state.common.outputs.key_vault_id
# tenant_id = data.azurerm_client_config.current.tenant_id
# object_id = data.azuread_service_principal.cosmosdb.id
resource "azurerm_key_vault_access_policy" "cosmosdb" {
key_vault_id = data.terraform_remote_state.common.outputs.key_vault_id
tenant_id = data.azurerm_client_config.current.tenant_id
object_id = data.azuread_service_principal.cosmosdb.id

# key_permissions = ["Get", "UnwrapKey", "WrapKey"]
# secret_permissions = ["Get"]
#}
key_permissions = ["Get", "UnwrapKey", "WrapKey"]
secret_permissions = ["Get"]
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ resource "azurerm_postgresql_server" "cmk" {

resource "azurerm_postgresql_server_key" "this" {
server_id = azurerm_postgresql_server.cmk.id
key_vault_key_id = data.terraform_remote_state.common.outputs.key_id
key_vault_key_id = azurerm_key_vault_key.this.id
}
1 change: 0 additions & 1 deletion auto_policy_testing/scripts/exception_rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"ecc-azure-345-mysql_infrastructure_encryption", #policy doesn't work
"ecc-azure-368-vmss_omi_vulnerability", #policy doesn't work
"ecc-azure-378-cis_nsg_flow_log_analytics", #policy doesn't work
"ecc-azure-201-asb_cosmosdb_encrypt_cmk", #policy work but need additional permissions
"ecc-azure-302-redis_cache_disabled_public_access", #python sdk should be updated
"ecc-azure-354-acr_anonymous_pull", #issue with policy, should be reviewed and fixed
"ecc-azure-143-asb_api_mgmt_vnet" #issue with terraform, should be reviewed and fixed
Expand Down

0 comments on commit e30dc3b

Please sign in to comment.