Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed incorrect calculation of image tokens for GTP-4o mini models #166

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: fixed incorrect calculation of image tokens for GTP-4o mini models #166

merged 1 commit into from
Nov 5, 2024

Conversation

adubovik
Copy link
Collaborator

@adubovik adubovik commented Nov 5, 2024 •
edited
Loading

Resolves #165

Configuration changes

Added a new GPT4O_MINI_DEPLOYMENTS env var.

The migration procedure

Move gpt-4o mini deployments from GPT4O_DEPLOYMENTS to this new GPT4O_MINI_DEPLOYMENTS env var:

Conf before:

GPT4O_DEPLOYMENTS=gpt-4o-depl1,gpt-4o-depl2,gpt-4o-mini-depl1,gpt-4o-mini-depl2

Conf after:

GPT4O_DEPLOYMENTS=gpt-4o-depl1,gpt-4o-depl2
GPT4O_MINI_DEPLOYMENTS=gpt-4o-mini-depl1,gpt-4o-mini-depl2

@adubovik adubovik self-assigned this Nov 5, 2024
@adubovik
Copy link
Collaborator Author

adubovik commented Nov 5, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-166.nightly-test.deltixhub.io
E2E tests status: success

@adubovik adubovik merged commit ca28d1d into development Nov 5, 2024
7 checks passed
@adubovik adubovik deleted the fix/fixed-image-tokenization-for-gpt4o-mini branch November 5, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-romanov-o roman-romanov-o roman-romanov-o approved these changes

Assignees

@adubovik adubovik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix token computation for images in gpt-4o-mini
2 participants
@adubovik @roman-romanov-o