Force rerender on image load to recalculate caption visibility #2652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Caption visibility depends on
<img>
width. But initially rendered<img>
has no image source loaded, so<img>
is small. After image loaded, it didn't trigger any React re-renders, so caption being hidden until follow up interactions with RTE occurs. When RTE initially rendered in readonly view, no follow up interactions can occur. So we need to force re-rerender image component when image source loaded.Issue link:
Closes #2650
QA notes:
Test RTE images(resizing, load, caption)