Service file for the filesystem monitor #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iivanou
force-pushed
the
fsmonitor_service
branch
2 times, most recently
from
b2848fa
to
53ec35d
Compare
AndreiPashkin
suggested changes
Sep 11, 2017
|
The fsmonitor file is one you are looking for. This script supports all necessary actions. See below: |
iivanou
force-pushed
the
fsmonitor_service
branch
3 times, most recently
from
f8bc290
to
bba542f
Compare
1. Add test for copy(recursive) events 2. Add test for move events 3. We are hanlding only importnant events now 4. Replace move events with necessary ones 5. Reorginize tests for the monitor funtionality 6. Add necessary attributes to the Event class to match protobuf entity 7. Add new protobuf entities: is_dir, is_deleted 8. Generate new DTO for new entities
iivanou
force-pushed
the
fsmonitor_service
branch
from
bba542f
to
b360768
Compare
| @@ -16,6 +16,8 @@ import "onedrive_client/entities/onedrive.proto"; | |||
| message LocalItemMetadata { | |||
| uint64 size = 1; | |||
| uint64 modified = 2; | |||
| bool is_dir = 3; | |||
| bool is_deleted = 4; | |||
| } | |||
There was a problem hiding this comment.
is_deleted definitely must be in DirtyLocalItem, because DirtyLocalItem reflects a change event (which includes deletion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template of a service file in LSB format.