🍦 Bring CUDA setup in sync with recent nixpkgs #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a subtle bug. The CUDA_TOOLKIT changed on the nix side and no longer contained the actual cuda driver. This lead to only the stubs being added to the runpath of CUDA executables. The stubs are only meant to be used at link time but not functional during runtime. This change prepends the runpath with the correct CUDA driver. Also removes the now obsolete `LL_CUDA_RUNTIME` flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subtle bug. The CUDA_TOOLKIT changed on the nix side and no longer contained the actual cuda driver. This lead to only the stubs being added to the runpath of CUDA executables. The stubs are only meant to be used at link time but not functional during runtime.
This change prepends the runpath with the correct CUDA driver.
Also removes the now obsolete
LL_CUDA_RUNTIMEflag.