Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdd from volodya-lombrozo #75

Merged
merged 1 commit into from
Jan 3, 2024
Merged

pdd from volodya-lombrozo #75

merged 1 commit into from
Jan 3, 2024

Conversation

h1alexbel
Copy link
Member

@h1alexbel h1alexbel commented Jan 3, 2024

PR-Codex overview

This PR focuses on updating the PDD action used in the workflow.

Detailed summary

  • Updated the PDD action from g4s8/pdd-action@master to volodya-lombrozo/pdd-action@master.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself
Copy link
Collaborator

zoeself commented Jan 3, 2024

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb3aea7) 100.00% compared to head (0bb56a1) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #75   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        10        10           
===========================================
  Files              3         3           
  Lines             35        35           
===========================================
  Hits              35        35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoeself
Copy link
Collaborator

zoeself commented Jan 3, 2024

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2024-01-06T06:29:54.914958.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel
Copy link
Member Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 3, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 0794bdb into master Jan 3, 2024
8 checks passed
@rultor
Copy link
Collaborator

rultor commented Jan 3, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 4min)

@zoeself
Copy link
Collaborator

zoeself commented Jan 3, 2024

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants