Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Jest to v25 #339

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Upgrade Jest to v25 #339

merged 1 commit into from
Mar 31, 2020

Conversation

Methuselah96
Copy link
Contributor

Resolves #334.
Reopens #335.

@blainekasten blainekasten merged commit e21e20e into enzymejs:master Mar 31, 2020
@Methuselah96 Methuselah96 deleted the jest-upgrade-2 branch March 31, 2020 12:31
@DanilAgafonov DanilAgafonov mentioned this pull request Sep 7, 2020
Open
@GreenGremlin
Copy link
Contributor

GreenGremlin commented Oct 16, 2020 •
edited
Loading

Can the version pin for jest-environment-jsdom be more open? It looks like it's only used in one place and a more loose version pin would allow jest-enzyme to be compatible with more versions of jest. As it currently stands, the dependecy on jest-environment-jsdom ends up pulling in pretty much the full jest dependency tree, which is not good if the consuming package is not on the same major version of jest. I just tried setting up jest-enzyme in a package running jest 26 and ended up with a bunch of jest 24 packages. I'm now getting typescript errors for jest being undefined, which I assume is caused by incompatible versions of jest being installed.

@Methuselah96
Copy link
Contributor Author

Methuselah96 commented Oct 16, 2020 •
edited
Loading

@GreenGremlin Yeah, agreed. I made #343 to address this, but it looks the maintainers are missing in action.

@csvan
Copy link

csvan commented Nov 18, 2020

@blainekasten seems like this needs to be published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update jest-environment-jsdom in jest-environment-enzyme
4 participants
@Methuselah96 @GreenGremlin @csvan @blainekasten