Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api(oidc): Add validation fields to OIDCProvider #5443

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

markwinter
Copy link

@markwinter markwinter commented Mar 8, 2025

What this PR does / why we need it:

This PR is the start of adding ID token validation when using OIDC authentication.

It adds the RemoteJWKS and Audience fields to the OIDCProvider.

The future intention is that when RemoteJWKS is set, the Issuer Audience and RemoteJWKS fields will be used to configure a JWT Filter that will validate the ID Token (using IdToken cookie)

Which issue(s) this PR fixes:

Reference #5414

Release Notes: No

@markwinter markwinter requested a review from a team as a code owner March 8, 2025 23:38
@markwinter markwinter changed the title feat(oidc): Add validation fields to OIDCProvider api(oidc): Add validation fields to OIDCProvider Mar 9, 2025
@zirain
Copy link
Member

zirain commented Mar 9, 2025

Can we add CEL validation rule for these rules?

@markwinter markwinter force-pushed the feat/oidc-token-validation-api branch from 66708fe to 83b865b Compare March 9, 2025 13:52
@markwinter markwinter force-pushed the feat/oidc-token-validation-api branch from a97c215 to f7f8d59 Compare March 9, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants