Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bypassing envoy overload manager for listeners #5441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rudrakhp
Copy link
Member

@rudrakhp rudrakhp commented Mar 8, 2025

What type of PR is this?

feat: support bypassing envoy overload manager for listeners
Also has a minor refactor of Listener IR struct that resolves a TODO.

What this PR does / why we need it:

To enable user to bypass overload manager for listeners. See #5260 for more details.

Which issue(s) this PR fixes:

Fixes #5260

Release Notes: Yes/No

@rudrakhp rudrakhp requested a review from a team as a code owner March 8, 2025 18:41
@rudrakhp rudrakhp force-pushed the bypass_overload_manager branch 3 times, most recently from 2ef640e to 2f51aac Compare March 8, 2025 19:28
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 85.91549% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.25%. Comparing base (12336d8) to head (316f332).

Files with missing lines Patch % Lines
internal/gatewayapi/clienttrafficpolicy.go 77.41% 5 Missing and 2 partials ⚠️
internal/xds/translator/translator.go 33.33% 0 Missing and 2 partials ⚠️
internal/xds/translator/listener.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5441      +/-   ##
==========================================
- Coverage   65.34%   65.25%   -0.09%     
==========================================
  Files         213      213              
  Lines       33915    33920       +5     
==========================================
- Hits        22162    22136      -26     
- Misses      10426    10450      +24     
- Partials     1327     1334       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rudrakhp rudrakhp force-pushed the bypass_overload_manager branch 2 times, most recently from 58e4284 to 6dcd267 Compare March 8, 2025 19:58
@rudrakhp rudrakhp force-pushed the bypass_overload_manager branch from 6dcd267 to 316f332 Compare March 8, 2025 20:03
// +k8s:deepcopy-gen=true
type TCPListener struct {
type TCPBasedListenerDetails struct {
CoreListenerDetails `json:",inline" yaml:",inline"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering if we should have CoreListenerDetails nested under TCPBasedListenerDetails, hierarchically it's correct but might be confusing.

@arkodg
Copy link
Contributor

arkodg commented Mar 8, 2025

can you explain this use case @rudrakhp ? im not sure why its required ? if a proxy is overloaded, we do want the health checks enabled on the listener to fail so the fronting LB can send new requests to another proxy w/o affecting existing requests/connections

@rudrakhp
Copy link
Member Author

rudrakhp commented Mar 9, 2025

From the conversation in the original issue, I was under the impression we do support custom health check probes, that might require users to set this option in custom listeners for these probes as well. Do correct me if this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support exclusion of listeners from overload manager
2 participants