-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support bypassing envoy overload manager for listeners #5441
base: main
Are you sure you want to change the base?
Conversation
2ef640e
to
2f51aac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5441 +/- ##
==========================================
- Coverage 65.34% 65.25% -0.09%
==========================================
Files 213 213
Lines 33915 33920 +5
==========================================
- Hits 22162 22136 -26
- Misses 10426 10450 +24
- Partials 1327 1334 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
58e4284
to
6dcd267
Compare
Signed-off-by: Rudrakh Panigrahi <[email protected]>
6dcd267
to
316f332
Compare
// +k8s:deepcopy-gen=true | ||
type TCPListener struct { | ||
type TCPBasedListenerDetails struct { | ||
CoreListenerDetails `json:",inline" yaml:",inline"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was wondering if we should have CoreListenerDetails
nested under TCPBasedListenerDetails
, hierarchically it's correct but might be confusing.
can you explain this use case @rudrakhp ? im not sure why its required ? if a proxy is overloaded, we do want the health checks enabled on the listener to fail so the fronting LB can send new requests to another proxy w/o affecting existing requests/connections |
From the conversation in the original issue, I was under the impression we do support custom health check probes, that might require users to set this option in custom listeners for these probes as well. Do correct me if this is not the case. |
What type of PR is this?
feat: support bypassing envoy overload manager for listeners
Also has a minor refactor of Listener IR struct that resolves a TODO.
What this PR does / why we need it:
To enable user to bypass overload manager for listeners. See #5260 for more details.
Which issue(s) this PR fixes:
Fixes #5260
Release Notes: Yes/No