feat [ratelimiting] support global ratelimit buckets

[ryanhristovski]

Core logic in internal/xds/translator/ratelimit.go

Description

Descriptor/Domain Changes

• If the ratelimit is shared the following values are set

Descriptor Key = BackendTrafficPolicy.Name
Descriptor Value = BackendTrafficPolicy.Namespace
Domain = BackendTrafficPolicy.Name + "-" BackendTrafficPolicy.Namespace

This will allow the ratelimit to be shared across all xRoutes/Gateways that share this BackendTrafficPolicy (BTP).

• If the ratelimit is not shared, it will use the listener name as the domain and maintain previous descriptor key/value of the route name.

HTTPFilter Changes

• Since we are now potentially using multiple domains, we needed to create multiple Ratelimit HTTPFilters to associate with them, buildRateLimitFilter now builds a list of filters.

API Changes

• GlobalRateLimit, now includes Shared value responsible for enabling this logic
• TrafficFeatures, responsible for holding all information associated to BTP, now includes BTP metadata including BTP.name and BTP.namespace (this is used for setting domains & descriptors)

Runner changes

• Runner now iterates through a list of Ratelimit configuration now that there can be multiple

Testing

• Ratelimit-config translator has been updated to build multiple configurations separated by --- in order to account for the multiple domains that are now being used.
• All tests have been updated to account for new traffic.BackendTrafficPolicy fields

TODO:

• Cleanup debugging logs
• Update shared=true logic to be whatever is decided api: sharing global ratelimit buckets #5227 (comment)
• Write some updated testing
• Add all updated tests (left out for now for easier reviewing)

[codecov]

Codecov Report

Attention: Patch coverage is 70.62937% with 84 lines in your changes missing coverage. Please review.

Project coverage is 65.26%. Comparing base (12336d8) to head (cfe8613).

Files with missing lines	Patch %	Lines
internal/xds/translator/ratelimit.go	64.78%	65 Missing and 16 partials ⚠️
internal/globalratelimit/runner/runner.go	72.72%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5361      +/-   ##
==========================================
- Coverage   65.34%   65.26%   -0.08%     
==========================================
  Files         213      213              
  Lines       33915    34062     +147     
==========================================
+ Hits        22162    22232      +70     
- Misses      10426    10489      +63     
- Partials     1327     1341      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ryanhristovski]

/retest