rm overwriteControlPlaneCerts from the EnvoyGateway API #5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was not implemented previously and instead must be specified as a cmd line arg for `certgen` Signed-off-by: Arko Dasgupta <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5088 +/- ##
==========================================
+ Coverage 66.81% 66.86% +0.05%
==========================================
Files 210 210
Lines 32953 32942 -11
==========================================
+ Hits 22017 22027 +10
+ Misses 9600 9582 -18
+ Partials 1336 1333 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Arko Dasgupta <[email protected]>
guydc
previously approved these changes
Jan 17, 2025
cnvergence
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was not implemented previously and instead must be specified as a cmd line arg for
certgen