Support StreamIdleTimeout #4350
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please ref the doc: https://gateway.envoyproxy.io/contributions/contributing/#submitting-a-pr and fix your DCO. thanks |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
arkodg
reviewed
Jan 3, 2025
Comment on lines
+79
to
+83
| // The stream idle timeout for connections managed by the connection manager. | ||
| // If not specified, this defaults to 5 minutes. The default value was selected | ||
| // so as not to interfere with any smaller configured timeouts that may have | ||
| // existed in configurations prior to the introduction of this feature, while | ||
| // introducing robustness to TCP connections that terminate without a FIN. |
There was a problem hiding this comment.
Suggested change
| // The stream idle timeout for connections managed by the connection manager. | |
| // If not specified, this defaults to 5 minutes. The default value was selected | |
| // so as not to interfere with any smaller configured timeouts that may have | |
| // existed in configurations prior to the introduction of this feature, while | |
| // introducing robustness to TCP connections that terminate without a FIN. | |
| // The stream idle timeout defines the amount of time a stream can exist without any upstream or downstream activity. | |
| // If not specified, this defaults to 5 minutes. |
|
can you also sign your commit and force push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat(translator):Support StreamIdleTimeout
What this PR does / why we need it:
Support StreamIdleTimeout
Which issue(s) this PR fixes:
Fixes #4349