dynamic_modules: republish every priority when removing cluster hosts - #47527
Merged
agrawroh merged 1 commit intoSep 19, 2026
Merged
Conversation
removeHosts rebuilt and republished only priority 0, so hosts removed from a higher priority were dropped from the internal map but their host set was never republished. Worker load balancers kept routing to the removed endpoints. removeHosts now republishes every priority that held a removed host. addHosts also records each host at its real priority so the cross priority host map is cleaned when higher priority hosts are removed. A unit test covers the higher priority republish, the untouched priority, the cross priority map cleanup, and a removal spanning priorities. Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
mathetake
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
removeHoststo republish every priority that held a removed host. Now,addHostswould also record each host at its real priority so the cross priority host map is cleaned when higher priority hosts are removed.Commit Message: dynamic_modules: republish every priority when removing cluster hosts
Risk Level: Low
Testing: Added Tests
Docs Changes: N/A
Release Notes: N/A