Conversation
Signed-off-by: Yuchen Wang <162491048+yuchen-db@users.noreply.github.com>
|
Hi @yuchen-db, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Member
|
/assign @yanavlasov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
AUTOandV4_PREFERREDmode, a no-records response from one address family can leave the combined result marked Completed even when the other lookup fails.STRICT_DNSconsumers can then replace their existing hosts with an empty list.Track lookup failures through completion and return Failure when no addresses were obtained. Successful fallback addresses and successful empty lookups remain supported. Intentionally filtered address families do not count as DNS failures.
Testing
bazel test --config=clang -c fastbuild //test/extensions/network/dns_resolver/cares:dns_impl_testpassed all 148 tests, including IPv4 and IPv6, in the official build image. Format and spelling checks passed.Docs Changes: Documented c-ares dual-family failure handling.
AI assistance: Codex assisted with the code and tests
Fixes #38752