Skip to content

dns: preserve failures in dual-family resolution - #47494

Open
yuchen-db wants to merge 1 commit into
envoyproxy:mainfrom
yuchen-db:fix/cares-empty-result-on-error
Open

yuchen-db wants to merge 1 commit into
envoyproxy:mainfrom
yuchen-db:fix/cares-empty-result-on-error

Conversation

@yuchen-db

@yuchen-db yuchen-db commented Sep 17, 2026

Copy link
Copy Markdown

In AUTO and V4_PREFERRED mode, a no-records response from one address family can leave the combined result marked Completed even when the other lookup fails. STRICT_DNS consumers can then replace their existing hosts with an empty list.

Track lookup failures through completion and return Failure when no addresses were obtained. Successful fallback addresses and successful empty lookups remain supported. Intentionally filtered address families do not count as DNS failures.

Testing

bazel test --config=clang -c fastbuild //test/extensions/network/dns_resolver/cares:dns_impl_test passed all 148 tests, including IPv4 and IPv6, in the official build image. Format and spelling checks passed.
Docs Changes: Documented c-ares dual-family failure handling.

AI assistance: Codex assisted with the code and tests

Fixes #38752

Signed-off-by: Yuchen Wang <162491048+yuchen-db@users.noreply.github.com>
@repokitteh-read-only

Copy link
Copy Markdown

Hi @yuchen-db, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #47494 was opened by yuchen-db.

see: more, trace.

@agrawroh

Copy link
Copy Markdown
Member

/assign @yanavlasov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: dns: c-ares: timeouts in dual-resolution can result in "no unhealthy backends"

3 participants