http: reject versionless CONNECT requests in legacy parser#46236
Open
nezdolik wants to merge 1 commit into
Open
http: reject versionless CONNECT requests in legacy parser#46236nezdolik wants to merge 1 commit into
nezdolik wants to merge 1 commit into
Conversation
Malformed CONNECT request lines that end before an HTTP version is parsed are treated as HTTP/0.9 by http-parser. Envoy then maps this to HTTP/1.0 and emits an HTTP/1.0 400 response. Reject versionless CONNECT requests in the parser so Envoy retains HTTP/1.1 for the error response. Add regression coverage for issue envoyproxy#28902. Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
nezdolik
force-pushed
the
leg-http-parser-connect-fix
branch
from
July 17, 2026 15:10
0946f78 to
4d243b3
Compare
RyanTheOptimist
approved these changes
Jul 17, 2026
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Should we consider a runtime guard?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject versionless CONNECT requests in the legacy HTTP parser.
Previously, these requests were treated as HTTP/0.9, causing Envoy to return an HTTP/1.0 error response. The parser now rejects them before protocol classification, preserving an HTTP/1.1 400 response.
Commit Message: Reject versionless CONNECT requests in the legacy HTTP parser.
Additional Description:
Risk Level:
Testing: Done
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes #28902