Skip to content

[bp/1.36] Set envoy_reloadable_features_http2_use_oghttp2=false by default (#42319) #46233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zmiklank wants to merge 1 commit into
base: release/v1.36
Choose a base branch
from
+3 −1
Open

[bp/1.36] Set envoy_reloadable_features_http2_use_oghttp2=false by default (#42319) #46233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/common/runtime/runtime_features.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ RUNTIME_GUARD(envoy_reloadable_features_http1_balsa_disallow_lone_cr_in_chunk_ex
RUNTIME_GUARD(envoy_reloadable_features_http2_discard_host_header);
RUNTIME_GUARD(envoy_reloadable_features_http2_include_cookies_in_limits);
RUNTIME_GUARD(envoy_reloadable_features_http2_propagate_reset_events);
RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2);
RUNTIME_GUARD(envoy_reloadable_features_http3_remove_empty_cookie);
// Delay deprecation and decommission until UHV is enabled.
RUNTIME_GUARD(envoy_reloadable_features_http_reject_path_with_fragment);
Expand Down Expand Up @@ -216,6 +215,9 @@ FALSE_RUNTIME_GUARD(envoy_reloadable_features_fixed_heap_use_allocated);
// TODO(yavlasov): Enabling by default will be hugely disruptive to existing traffic.
// Replace with a config option (default off) post CVE release.
FALSE_RUNTIME_GUARD(envoy_reloadable_features_reject_early_connect_data);
// Flip back to true once performance aligns with nghttp2 and
// https://github.com/envoyproxy/envoy/issues/40070 is resolved.
FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2);

// Enable histograms of HTTP/2 header sizes, including cookie size.
FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_record_histograms);
Expand Down
Loading