Skip to content

Delflake //test/integration:circuit_breakers_integration_test#46195

Open
yanavlasov wants to merge 1 commit into
envoyproxy:mainfrom
yanavlasov:deflake-circuit-breaker-test
Open

Delflake //test/integration:circuit_breakers_integration_test#46195
yanavlasov wants to merge 1 commit into
envoyproxy:mainfrom
yanavlasov:deflake-circuit-breaker-test

Conversation

@yanavlasov

Copy link
Copy Markdown
Contributor

The test needed to wait for main thread to complete the ejection task before sending the next request.

Risk Level: none
Testing: unit test
Docs Changes: no
Release Notes: no
Platform Specific Features: no

Signed-off-by: Yan Avlasov <yavlasov@google.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several integration tests in circuit_breakers_integration_test.cc by adding a wait condition for the cluster.cluster_0.outlier_detection.ejections_enforced_total counter to reach 1. This ensures that the main thread has successfully ejected the host before subsequent requests are sent, preventing potential race conditions. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@yanavlasov
yanavlasov enabled auto-merge (squash) July 16, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant