matching: added a new local reply matcher input to distinguish Envoy generated responses#43838
Merged
yanavlasov merged 5 commits intoenvoyproxy:mainfrom Mar 11, 2026
Merged
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
…responses Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
feat-local-reply-matcher
branch
from
2e66e09 to
025a41b
Compare
Member
|
/lgtm api |
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Contributor
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new HttpResponseLocalReplyMatchInput to differentiate between local replies generated by Envoy and responses from upstream services. The implementation is clear, correct, and includes comprehensive unit and integration tests that validate the new functionality, especially in conjunction with the custom_response filter. The changes are well-structured and align with existing code patterns, and the documentation and changelog entries are clear. No issues were found during the review.
yanavlasov
approved these changes
Mar 11, 2026
Member
Author
|
/retest |
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…generated responses (envoyproxy#43838) ## Description This PR adds a new local reply matcher input to distinguish Envoy generated local replies from upstream responses. This matcher input returns `true` for local replies and `false` for upstream responses, enabling `custom_response` filter policies to selectively apply only to locally generated error responses. Fix envoyproxy#43811 --- **Commit Message:** matching: added a new local reply matcher input to distinguish Envoy generated responses **Additional Description:** Added a new local reply matcher input to distinguish Envoy generated local replies from upstream responses. **Risk Level:** Low **Testing:** Added Unit + Integration Tests **Docs Changes:** Added **Release Notes:** Added Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…generated responses (envoyproxy#43838) ## Description This PR adds a new local reply matcher input to distinguish Envoy generated local replies from upstream responses. This matcher input returns `true` for local replies and `false` for upstream responses, enabling `custom_response` filter policies to selectively apply only to locally generated error responses. Fix envoyproxy#43811 --- **Commit Message:** matching: added a new local reply matcher input to distinguish Envoy generated responses **Additional Description:** Added a new local reply matcher input to distinguish Envoy generated local replies from upstream responses. **Risk Level:** Low **Testing:** Added Unit + Integration Tests **Docs Changes:** Added **Release Notes:** Added Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new local reply matcher input to distinguish Envoy generated local replies from upstream responses. This matcher input returns
truefor local replies andfalsefor upstream responses, enablingcustom_responsefilter policies to selectively apply only to locally generated error responses.Fix #43811
Commit Message: matching: added a new local reply matcher input to distinguish Envoy generated responses
Additional Description: Added a new local reply matcher input to distinguish Envoy generated local replies from upstream responses.
Risk Level: Low
Testing: Added Unit + Integration Tests
Docs Changes: Added
Release Notes: Added