eds: key LEDS maps by collection name string instead of protobuf#43820
Open
wdauchy wants to merge 1 commit intoenvoyproxy:mainfrom
Open
eds: key LEDS maps by collection name string instead of protobuf#43820wdauchy wants to merge 1 commit intoenvoyproxy:mainfrom
wdauchy wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
wdauchy
force-pushed
the
wdauchy/leds-optimize-map-lookups
branch
from
f1d51ed to
c0969aa
Compare
LedsConfigMap and LedsConfigSet used the full LedsClusterLocalityConfig protobuf as key with MessageUtil, which does TextFormat::PrintToString for hashing and MessageDifferencer::Equals for comparison on every lookup. Since the leds_collection_name xDSTP URL uniquely identifies a LEDS subscription, use it as a plain string key instead. This also fixes a triple hash-map lookup in batchUpdate() (find, operator[], operator[] again) by reusing the iterator from a single find() call. Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
wdauchy
force-pushed
the
wdauchy/leds-optimize-map-lookups
branch
from
c0969aa to
dad9efe
Compare
Contributor
Author
|
/retest transients |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
LedsConfigMap and LedsConfigSet used the full LedsClusterLocalityConfig protobuf as key with MessageUtil, which does TextFormat::PrintToString for hashing and MessageDifferencer::Equals for comparison on every lookup. Since the leds_collection_name xDSTP URL uniquely identifies a LEDS subscription, use it as a plain string key instead.
This also fixes a triple hash-map lookup in batchUpdate() (find, operator[], operator[] again) by reusing the iterator from a single find() call.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]