Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #42190 was opened by mmorel-35.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 22, 2025
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #42190 was opened by mmorel-35.

see: more, trace.

@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 3 times, most recently from 3cf696c to 2ab02ca Compare November 22, 2025 13:49
@mmorel-35 mmorel-35 changed the title deps: bzlmod migration with BCR dependencies and non-module extension deps: bzlmod migration with BCR dependencies Nov 22, 2025
@mmorel-35 mmorel-35 marked this pull request as ready for review November 22, 2025 14:03
Comment on lines +201 to +237
python.toolchain(
is_default = True,
python_version = "3.12",
)
use_repo(
python,
"python_3_12",
python = "python_versions",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Python 3.14 out, can this be bumped to at least 3.13?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python update should be handled separately - 3.13 added a lot of breaking change so ive held off so far

Comment on lines +201 to +237
python.toolchain(
is_default = True,
python_version = "3.12",
)
use_repo(
python,
"python_3_12",
python = "python_versions",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Python 3.14 out, can this be bumped to at least 3.13?

@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 18 times, most recently from f42bfdd to 5728c9c Compare December 15, 2025 18:14
@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 4 times, most recently from 99b1612 to 7eaedaa Compare December 16, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants