-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext_proc: template gRPC client and move it to common folder #38898
Conversation
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
/retest |
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coverage LGTM
LGTM in general. Thanks for working on this refactoring! |
Signed-off-by: Boteng Yao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review, done.
Templates are great to provide flexible interfaces but it also will make interface/code more complicated. As we can see in this PR , template arguments are passed around/specified through the multiple layers in the stack. Some high level comments:
It seems to be a major change, I don't have strong opinion if 1 above is working |
Thanks Tianyu for the review. yes it will work with the new l4 ext_proc, and I think this can be shared for other cases as well for different message types. Good to know CTAD, I will explore it, can it be a follow up? Thanks! |
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up actions are fine to me.
it will be great to reduce the code complexity (i.e., have easy to maintain code) while leveraging's template's power of writing generic code.
This PR will make the gRPC external processor client in l7_ext_proc share with the l4_ext_proc filter.
Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes: