Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump bazel #37789

Closed
wants to merge 2 commits into from
Closed

ci: bump bazel #37789

wants to merge 2 commits into from

Conversation

zirain
Copy link
Member

@zirain zirain commented Dec 23, 2024

Commit Message: istio proxy failed to build with bazel 7.1.2, and passed with 7.2.0, see istio/proxy#6023
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: zirain <[email protected]>
@zirain zirain mentioned this pull request Dec 23, 2024
@phlax
Copy link
Member

phlax commented Dec 23, 2024

@zirain as you can see from the CI this is not currently possible due to a bazel bug which causes our mobile/coverage to fail

7.1.2 is as high as we can go with current bazel so we will need to either jump to 8 or >7.5 if the bugfix is backported

this is the bug - bazelbuild/bazel#23247

out of interest does bumping the bazel version fix the issue istio has?

@zirain
Copy link
Member Author

zirain commented Dec 23, 2024

istio/proxy#6023 showed that bumping the bazel will help.

I can give a try with 7.5+

@phlax phlax self-assigned this Dec 23, 2024
@phlax
Copy link
Member

phlax commented Dec 23, 2024

cc @keith

Signed-off-by: zirain <[email protected]>
@zirain zirain changed the title ci: bump to bazel 7.2 ci: bump bazel Dec 24, 2024
@zirain
Copy link
Member Author

zirain commented Dec 24, 2024

failed with bazel 8 and expected first release candidate date if 7.5 is 2025-01-13.

@phlax
Copy link
Member

phlax commented Dec 24, 2024

cc @keith wondering if we can get the fix included in the 7.5 release

@zirain one workaround might be for istio to adjust the bazel version in a patch - i think that wont break anything altho not 100%

@zirain
Copy link
Member Author

zirain commented Dec 25, 2024

@zirain one workaround might be for istio to adjust the bazel version in a patch - i think that wont break anything altho not 100%

I commented the sync code of .bazelversion file, so it won't be a blocker.
It would be better we can enable it soon.

@zirain
Copy link
Member Author

zirain commented Jan 3, 2025

closed as #37864.

@zirain zirain closed this Jan 3, 2025
@zirain zirain deleted the bump-bazel branch January 3, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants