Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Add EngineBuilder::setDnsNumRetries #35906

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented Aug 29, 2024

This PR adds a configuration to set the number of DNS retries. If not specified, the DNS resolver will indefinitely retry until it succeeds or the DNS query times out.

Risk Level: low (a new feature)
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

Signed-off-by: Fredy Wijaya <[email protected]>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #35906 was opened by fredyw.

see: more, trace.

Signed-off-by: Fredy Wijaya <[email protected]>
Signed-off-by: Fredy Wijaya <[email protected]>
Signed-off-by: Fredy Wijaya <[email protected]>
Signed-off-by: Fredy Wijaya <[email protected]>
@fredyw fredyw marked this pull request as ready for review August 29, 2024 16:59
@fredyw
Copy link
Member Author

fredyw commented Aug 29, 2024

/assign @abeyad

@abeyad abeyad merged commit db12a70 into envoyproxy:main Aug 29, 2024
31 checks passed
@fredyw fredyw deleted the dns_num_retries branch August 30, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants