Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Fix for s3 double encoding #35048

Merged
merged 1 commit into from
Jul 6, 2024

Fix for s3 double encoding

b1a8c61
Select commit
Loading
Failed to load commit list.
Merged

aws: Fix for s3 double encoding #35048

Fix for s3 double encoding
b1a8c61
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Perf skipped Jul 3, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/35048/main@b1a8c61)

nbaws @nbaws b1a8c61 #35048 merge main@2296267

aws: Fix for s3 double encoding

Commit Message: aws: Fix for s3 double encoding
Additional Description:

Bugfix for issue #35023 . Includes additional unit tests and support for s3-outposts which also has the same workaround in the SDK for double encoding.

Risk Level: Low
Testing: Unit
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] 35023
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Environment

Request variables

Key Value
ref c83cb44
sha b1a8c61
pr 35048
base-sha 2296267
actor nbaws @nbaws
message aws: Fix for s3 double encoding...
started 1720012723.812823
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 31
patch 0
dev true