Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VHost metadata in logs and attributes #34900

Open
guydc opened this issue Jun 25, 2024 · 1 comment
Open

VHost metadata in logs and attributes #34900

guydc opened this issue Jun 25, 2024 · 1 comment
Labels
area/access_log help wanted Needs help!

Comments

@guydc
Copy link

guydc commented Jun 25, 2024

Title: VHost metadata in logs and attributes

Description:
Envoy resource metadata (e.g. route, cluster and listener metadata) is typically supported in the following:

  • Access Logging: Metadata can be logged using the metadata formatter extension (%METADATA(*:key)%)
  • Attributes: metadata can be accessed through an attribute (xds.*_metadata)

VHost metadata was introduced in #30175. VHost metadata should also support these capabilities.

Relevant Links:
@guydc guydc added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jun 25, 2024
@guydc guydc mentioned this issue Jun 25, 2024
Open
@mattklein123 mattklein123 added help wanted Needs help! area/access_log and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jun 25, 2024
@mathetake mathetake mentioned this issue Jun 27, 2024
Open
@mathetake
Copy link
Member

I just opened the PR for this: #34958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/access_log help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattklein123 @mathetake @guydc