-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Route and VHost Metadata #3318
Comments
💯 This type of stuff is super useful to get metadata per route or per ext_authz filter, etc. Makes it a lot easier to provide context about things like:
|
During the community meeting, the following proposal was raised:
For example: apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
name: http-app-1
annotations:
route.metadata.gateway.envoyproxy.io/rules: |
rules:
- rule1:
team: ops
app: commerce
spec:
parentRefs:
- name: my-gateway
hostnames:
- "foo.com"
rules:
- matches:
name: rule1
- path:
type: PathPrefix
value: /bar
backendRefs:
- name: my-service1
port: 8080 Will lead to the generated xds route corresponding to rule1 to have the following static metadata : This approach has several limitations:
|
+1 for mapping Gateway API fields ( like
|
In high level, I think that the following makes sense:
Of course, we don't have to implement everything immediately.
Since annotations are filtered and the other metadata is constrained in size, I think that adding the relevant Listener/Route/Cluster metadata will not inflate XDS too much. Users can decide if they want to add this metadata to their access logs and/or other telemetry. WDYT? |
+1 to this @guydc |
note: VHost metadata, which is a reasonable target for GW/Listener metadata, is currently not accessible for access logger/attribute consuming extensions: envoyproxy/envoy#34900. However, it can still be beneficial to annotate Vhosts for blame tooling like #3648. |
closed with: #3602 |
Description:
In Envoy, static metadata can be configured on virtual hosts, routes, clusters, etc.
Static metadata can be used for various purposes:
In the context of Envoy Gateway, route metadata can be beneficial for observability and configuration of custom data-plane extensions, as described above.
Envoy gateway can support route metadata using:
The text was updated successfully, but these errors were encountered: