remove unused code

Signed-off-by: Zhang Bo <[email protected]>
envoyproxy · Jul 3, 2024 · 13f95a6 · 13f95a6
1 parent 849f58f
commit 13f95a6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/source/common/tls/context_config_impl.cc b/source/common/tls/context_config_impl.cc
@@ -487,10 +487,12 @@ ServerContextConfigImpl::ServerContextConfigImpl(
     session_timeout_ =
         std::chrono::seconds(DurationUtil::durationToSeconds(config.session_timeout()));
   }
-  auto session_cache_timeout = std::chrono::milliseconds(
+  if (config.has_session_cache_service()) {
+    auto session_cache_timeout = std::chrono::milliseconds(
       DurationUtil::durationToMilliseconds(config.session_cache_service().timeout()));
-  tls_session_cache_client_ = SessionCache::tlsSessionCacheClient(
+    tls_session_cache_client_ = SessionCache::tlsSessionCacheClient(
       factory_context, config.session_cache_service().grpc_service(), session_cache_timeout);
+  }
 }
 
 void ServerContextConfigImpl::setSecretUpdateCallback(std::function<absl::Status()> callback) {

diff --git a/source/common/tls/session_cache/session_cache_impl.cc b/source/common/tls/session_cache/session_cache_impl.cc
@@ -26,7 +26,7 @@ GrpcClientImpl::GrpcClientImpl(Grpc::RawAsyncClientSharedPtr& async_client,
       service_method_(*Protobuf::DescriptorPool::generated_pool()->FindMethodByName(
           "envoy.service.tls_session_cache.v3.TlsSessionCacheService.TlsSession")) {}
 
-GrpcClientImpl::~GrpcClientImpl() { ASSERT(!callbacks_); }
+GrpcClientImpl::~GrpcClientImpl() {}
 
 void GrpcClientImpl::storeTlsSessionCache(Network::TransportSocketCallbacks* callbacks, SSL* ssl,
                                           int index, const std::string& session_id,