Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stopAndWait() hang when -Owholemodule #53

Merged
merged 1 commit into from
May 13, 2018
Merged

Fix stopAndWait() hang when -Owholemodule #53

merged 1 commit into from
May 13, 2018

Conversation

Interfere
Copy link
Contributor

This merge request fixes / refers to the following issues: #31

@fangpenlin
Copy link
Contributor

@Interfere ah, so the write operation got stripped out in the assert statement during Swift compiler optimization, that's a good caught. Thanks for fixing this problem! 👍

@fangpenlin fangpenlin merged commit e981038 into envoy:master May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Interfere @fangpenlin