Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: remove default template type #991

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Feat: remove default template type #991

merged 2 commits into from
Dec 19, 2024

Conversation

TomerHeber
Copy link
Collaborator

Part of #989

Solution

Breaking change:

  1. Remove the default template type, make it a required field.
  2. Updated acceptance tests.

@TomerHeber TomerHeber self-assigned this Dec 17, 2024
@TomerHeber
Copy link
Collaborator Author

/review

@bot-env0 bot-env0 requested a review from a team December 17, 2024 12:51
@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Dec 19, 2024
@TomerHeber TomerHeber merged commit 0a72aa4 into main Dec 19, 2024
4 checks passed
@TomerHeber TomerHeber deleted the feat-remove-default-template-type-#989 branch December 19, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaronya yaronya yaronya approved these changes

Assignees

@TomerHeber TomerHeber

Labels
feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomerHeber @yaronya