-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add the option to add a regex filter for list of teams #984
Conversation
/review |
@TomerHeber Im not sure how exactly it resolves #982
This PR's implementation filters the full backend response. |
Hi @liranfarage89 : Have you observed the discussion in: In addition we are now caching the API call. The full teams list will be stored in memory (for every terraform execution). |
@TomerHeber I read it and still don't get why this filter is necessary as long as the user suggested a workaround that basically does the same |
Got it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Writing here for future reference:
Although the filter happens in the client, the teams are globally cached.
Issue & Steps to Reproduce / Feature Request
resolves #982
Solution