Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Creation Policy for Environment discovery Configuration #1001

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Feat: Add Creation Policy for Environment discovery Configuration #1001

merged 3 commits into from
Jan 30, 2025

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #1000

Solution

  1. Updated the API - added missing field.
  2. Updated the schema - added the missing field.
  3. Updated the acceptance tests.
  4. Updated the integration test.
  5. Found a bug and fixed it as well (for 'is_terragrunt_run_all').

@TomerHeber TomerHeber self-assigned this Jan 13, 2025
@TomerHeber
Copy link
Collaborator Author

/review

@bot-env0 bot-env0 requested a review from a team January 13, 2025 17:10
Wassap124
Wassap124 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Wassap124 Wassap124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@github-actions github-actions bot added the ready to merge PR approved - can be merged once the PR owner is ready label Jan 29, 2025
@TomerHeber TomerHeber merged commit e5d5653 into main Jan 30, 2025
4 checks passed
@TomerHeber TomerHeber deleted the feat-add-flag-#1000 branch January 30, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wassap124 Wassap124 Wassap124 approved these changes

Assignees

@TomerHeber TomerHeber

Labels
api-client feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Creation Policy for Environment discovery Configuration
2 participants
@TomerHeber @Wassap124