fix: clean up stale miner data when hotkey re-links to new GitHub account#340
Open
tmimmanuel wants to merge 1 commit intoentrius:testfrom
Open
fix: clean up stale miner data when hotkey re-links to new GitHub account#340tmimmanuel wants to merge 1 commit intoentrius:testfrom
tmimmanuel wants to merge 1 commit intoentrius:testfrom
Conversation
Collaborator
|
just merged big changes into test please fix conflicts thanks |
7fdfa41 to
544b6df
Compare
Author
|
@anderdc I resolved merge conflicts, plz review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github_idre-registering on a new(uid, hotkey)(uid, hotkey)linking to a newgithub_id— old GitHub's rows were never deletedCLEANUP_STALE_*_BY_HOTKEY) and call them incleanup_stale_miner_data()Scenario
Related entrius/gittensor-ui#124

