Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propostal to use relay experimental #118

Merged
merged 8 commits into from
Nov 20, 2019
Merged

Propostal to use relay experimental #118

merged 8 commits into from
Nov 20, 2019

Conversation

thicodes
Copy link
Collaborator

About UserList, will we add routes+preloadQuery in preparation or preparedloadQuery within itself?

@renanmav
Copy link
Collaborator

How would you preload the query?

sibelius
sibelius reviewed Nov 20, 2019
View reviewed changes
packages/web/src/App.tsx Outdated Show resolved Hide resolved
sibelius
sibelius approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@sibelius sibelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good first step

@thicodes
Copy link
Collaborator Author

@renanmav
So, I thought of these 2 solutions:

  • Do inside the UserList. It is simpler, but it would be inappropriate.
  • Use routes - It would be closer to actual use as the issue-tracker.

What do you think?

@thicodes thicodes merged commit 7ed1708 into entria:master Nov 20, 2019
@thicodes thicodes deleted the chore/relay-react-experimental branch November 20, 2019 19:59
@renanmav
Copy link
Collaborator

Both solutions are valid. I prefer to preload on mouse hover.

@thicodes
Copy link
Collaborator Author

thicodes commented Nov 20, 2019 •
edited
Loading

@renanmav
Great! Im going to create a package with an issue-tracker router abstraction and bring the routes, creating a new PR. Thanks!

@renanmav
Copy link
Collaborator

Actually I'm already working on this here with Typescript flow fede \o/

@thicodes
Copy link
Collaborator Author

Wow. Very good!
Thank you very much. I will need a lot @renanmav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sibelius sibelius sibelius approved these changes

@AugustoCalaca AugustoCalaca Awaiting requested review from AugustoCalaca

@matheus1lva matheus1lva Awaiting requested review from matheus1lva

@miltoneiji miltoneiji Awaiting requested review from miltoneiji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thicodes @renanmav @sibelius