Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple typo fixes in README #598

Merged
merged 10 commits into from
Aug 12, 2024
Merged

Simple typo fixes in README #598

merged 10 commits into from
Aug 12, 2024

Conversation

umarbutler
Copy link
Contributor

This pull request makes a number of simple fixes to typos in the README, including rephrasing awkward constructions, correcting grammar mistakes and otherwise making it more natural.

Copy link
Collaborator

@junkmd junkmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

Documentation often doesn't get maintained regularly, so I appreciate PRs like this.

I think there might be better ways to present the content in the README, so I would like to offer a few suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
umarbutler and others added 3 commits August 9, 2024 21:36
Co-authored-by: Jun Komoda <[email protected]>
Co-authored-by: Jun Komoda <[email protected]>
Co-authored-by: Jun Komoda <[email protected]>
@umarbutler
Copy link
Contributor Author

LGTM 🚀

Copy link
Collaborator

@junkmd junkmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider these expressions as well.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
umarbutler and others added 4 commits August 11, 2024 18:11
Co-authored-by: Jun Komoda <[email protected]>
Co-authored-by: Jun Komoda <[email protected]>
Co-authored-by: Jun Komoda <[email protected]>
Co-authored-by: Jun Komoda <[email protected]>
@umarbutler
Copy link
Contributor Author

Please consider these expressions as well.

Approved.

junkmd added a commit to junkmd/pywinauto that referenced this pull request Aug 12, 2024
@junkmd junkmd merged commit a9f83d1 into enthought:main Aug 12, 2024
49 checks passed
@junkmd junkmd added this to the 1.4.7 milestone Aug 12, 2024
@umarbutler umarbutler deleted the patch-1 branch August 13, 2024 03:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants